Move AudioRendererImpl construction to WebMediaPlayerImpl.

Move AudioRendererImpl construction to WebMediaPlayerImpl.

This is extracted from a larger CL created by scherkus@: https://codereview.chromium.org/11468033/

BUG=none
TEST=media_unittests pass


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173019

[xhwang, 2012-12-13 07:08:18]

It's actually your change. PTAL :)

https://codereview.chromium.org/11564007/diff/1/webkit/media/webmediaplayer_i...
File webkit/media/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/11564007/diff/1/webkit/media/webmediaplayer_i...
webkit/media/webmediaplayer_impl.cc:132: media::AudioRendererSink*
audio_renderer_sink,
hmm, shall we pass const scoped_refptr<> here? audio_source_provider and
audio_renderer_sink is actually the same thing. They are passed here twice, one
is raw pointer and the other is ref counted... sigh...

[scherkus (not reviewing), 2012-12-13 16:09:32]

lgtm!

https://codereview.chromium.org/11564007/diff/1/webkit/media/webmediaplayer_i...
File webkit/media/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/11564007/diff/1/webkit/media/webmediaplayer_i...
webkit/media/webmediaplayer_impl.cc:132: media::AudioRendererSink*
audio_renderer_sink,
On 2012/12/13 07:08:18, xhwang wrote:
> hmm, shall we pass const scoped_refptr<> here? audio_source_provider and
> audio_renderer_sink is actually the same thing. They are passed here twice,
one
> is raw pointer and the other is ref counted... sigh...

yeah this is silliness

see https://code.google.com/p/chromium/issues/detail?id=136442

[commit-bot: I haz the power, 2012-12-13 20:02:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/11564007/6002

[commit-bot: I haz the power, 2012-12-13 20:02:51]

Presubmit check for 11564007-6002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/renderer

[xhwang, 2012-12-13 20:08:18]

jamesr@: could you please do an OWNERS review on
content/renderer/render_view_impl.cc

[jamesr, 2012-12-13 20:36:25]

lgtm

[commit-bot: I haz the power, 2012-12-13 20:37:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/11564007/6002

[commit-bot: I haz the power, 2012-12-14 00:40:15]

Change committed as 173019