Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: content/renderer/render_view_impl.cc

Issue 11564007: Move AudioRendererImpl construction to WebMediaPlayerImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase only Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/media/webmediaplayer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 21b30de751a5e3760cc887bf50099375046acaa7..4a6d2ba642ed203ccbe654b4253b528c56e4a43c 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2587,17 +2587,10 @@ WebMediaPlayer* RenderViewImpl::createMediaPlayer(
RenderAudioSourceProvider* audio_source_provider = NULL;
- // Add in any custom filter factories first.
+ // |audio_source_provider| "provides" audio to WebKit and is a sink from the
+ // perspective of the audio renderer.
if (!cmd_line->HasSwitch(switches::kDisableAudio)) {
- // audio_source_provider is a "provider" to WebKit, and a sink
- // from the perspective of the audio renderer.
audio_source_provider = new RenderAudioSourceProvider(routing_id_);
-
- // Add the chrome specific audio renderer, using audio_source_provider
- // as the sink.
- media::AudioRendererImpl* audio_renderer =
- new media::AudioRendererImpl(audio_source_provider);
- collection->AddAudioRenderer(audio_renderer);
}
WebGraphicsContext3DCommandBufferImpl* context3d = NULL;
« no previous file with comments | « no previous file | webkit/media/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698