Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: sky/engine/core/painting/CanvasImage.h

Issue 1156003007: Refactor image handling in Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: CR feedback from abarth Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/painting/CanvasImage.h
diff --git a/sky/engine/core/painting/CanvasImage.h b/sky/engine/core/painting/CanvasImage.h
index 1f40d7bab83124db57b22bf2cb5aa7663c0f828f..c92e9ebd9885a4287ad9e4cf48d24f9515d1bd09 100644
--- a/sky/engine/core/painting/CanvasImage.h
+++ b/sky/engine/core/painting/CanvasImage.h
@@ -5,7 +5,6 @@
#ifndef SKY_ENGINE_CORE_PAINTING_CANVASIMAGE_H_
#define SKY_ENGINE_CORE_PAINTING_CANVASIMAGE_H_
-#include "sky/engine/core/loader/NewImageLoader.h"
#include "sky/engine/platform/weborigin/KURL.h"
#include "sky/engine/tonic/dart_wrappable.h"
#include "sky/engine/wtf/PassRefPtr.h"
@@ -15,8 +14,7 @@
namespace blink {
class CanvasImage final : public RefCounted<CanvasImage>,
- public DartWrappable,
- public NewImageLoaderClient {
+ public DartWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
~CanvasImage() override;
@@ -25,21 +23,13 @@ class CanvasImage final : public RefCounted<CanvasImage>,
int width() const;
int height() const;
- KURL src() const { return srcURL_; }
- void setSrc(const String&);
-
const SkBitmap& bitmap() const { return bitmap_; }
void setBitmap(const SkBitmap& bitmap) { bitmap_ = bitmap; }
private:
CanvasImage();
- // NewImageLoaderClient
- void OnLoadFinished(const SkBitmap& result) override;
-
- KURL srcURL_;
SkBitmap bitmap_;
- OwnPtr<NewImageLoader> imageLoader_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698