Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: sky/engine/core/painting/CanvasImage.cpp

Issue 1156003007: Refactor image handling in Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: CR feedback from abarth Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/painting/CanvasImage.cpp
diff --git a/sky/engine/core/painting/CanvasImage.cpp b/sky/engine/core/painting/CanvasImage.cpp
index b9bed98dc15f82e33836b8cda0f7e0ab203ccc4b..f21d588f62c497457aa4aba47691b86c72bcfd17 100644
--- a/sky/engine/core/painting/CanvasImage.cpp
+++ b/sky/engine/core/painting/CanvasImage.cpp
@@ -7,7 +7,7 @@
namespace blink {
-CanvasImage::CanvasImage() : imageLoader_(adoptPtr(new NewImageLoader(this))) {
+CanvasImage::CanvasImage() {
}
CanvasImage::~CanvasImage() {
@@ -21,19 +21,4 @@ int CanvasImage::height() const {
return bitmap_.height();
}
-void CanvasImage::setSrc(const String& url) {
- // TODO(jackson): Figure out how to determine the proper base URL here
- KURL newSrcURL = KURL(KURL(), url);
- if (srcURL_ != newSrcURL) {
- srcURL_ = newSrcURL;
- imageLoader_->Load(srcURL_);
- }
-}
-
-void CanvasImage::OnLoadFinished(const SkBitmap& result) {
- // TODO(jackson): We'll eventually need a notification pathway for
- // when the image load is complete so that we know to repaint, etc.
- bitmap_ = result;
-}
-
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698