sky/engine/core/loader/ImageLoader.idl - Issue 1156003007: Refactor image handling in Sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/loader/ImageLoader.idl

Issue 1156003007: Refactor image handling in Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: CR feedback from abarth Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/loader/ImageLoader.idl

diff --git a/sky/engine/core/frame/ImageBitmap.idl b/sky/engine/core/loader/ImageLoader.idl

similarity index 55%

copy from sky/engine/core/frame/ImageBitmap.idl

copy to sky/engine/core/loader/ImageLoader.idl

index 903a2d7421f10c16804e3e29f10767cd7d119251..c4f7723958ac81ea6303cf53bf2780457c448803 100644

--- a/sky/engine/core/frame/ImageBitmap.idl

+++ b/sky/engine/core/loader/ImageLoader.idl

@@ -3,7 +3,8 @@

// found in the LICENSE file.

[

-] interface ImageBitmap {

- readonly attribute long width;

- readonly attribute long height;

+ Constructor(DOMString src, ImageLoaderCallback callback),

+ ImplementedAs=CanvasImageLoader,

+] interface ImageLoader {

+ void load();

abarth-chromium 2015/06/01 23:24:49 What's the point of having a |load| function anymo

};