'quotes' property is serialized wrongly on inline styles

'quotes' property is serialized wrongly on inline styles

Changed 'quotes' property to be serialized with space separators
instead of comma separators.

BUG=491787
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195973

[ramya.v, 2015-05-27 08:09:45]

ramya.v@samsung.com changed reviewers:
+ rob.buis@chromium.org, timloh@chromium.org

[ramya.v, 2015-05-27 08:09:45]

PTAL!
Do I need to add test case?

Thanks

[Timothy Loh, 2015-05-27 08:15:00]

On 2015/05/27 08:09:45, ramya.v wrote:
> PTAL!
> Do I need to add test case?
> 
> Thanks

Behaviour changes should usually come with tests. Maybe extending the test at
fast/css/quotes-parsing.html would be a good idea?

[ramya.v, 2015-05-27 08:46:31]

On 2015/05/27 08:15:00, Timothy Loh wrote:
> On 2015/05/27 08:09:45, ramya.v wrote:
> > PTAL!
> > Do I need to add test case?
> > 
> > Thanks
> 
> Behaviour changes should usually come with tests. Maybe extending the test at
> fast/css/quotes-parsing.html would be a good idea?

Extended test at fast/css/quotes-parsing.html. PTAL!

[Timothy Loh, 2015-05-27 09:11:37]

https://codereview.chromium.org/1155983003/diff/20001/LayoutTests/fast/css/qu...
File LayoutTests/fast/css/quotes-parsing.html (right):

https://codereview.chromium.org/1155983003/diff/20001/LayoutTests/fast/css/qu...
LayoutTests/fast/css/quotes-parsing.html:13: assert_equals(div.style.quotes,
"\"a\" \"b\"");
If you use a single-quoted string, you don't need the backslashes, i.e. '"a"
"b"'

https://codereview.chromium.org/1155983003/diff/20001/LayoutTests/fast/css/qu...
LayoutTests/fast/css/quotes-parsing.html:14: }, "Invalid strings for quotes
property do not parse and valid strings should be serialized by space
separator");
Can you pull out the added test into a separate test() call?

[ramya.v, 2015-05-27 09:22:15]

Updated as per review comments.
PTAL!

Thanks

https://codereview.chromium.org/1155983003/diff/20001/LayoutTests/fast/css/qu...
File LayoutTests/fast/css/quotes-parsing.html (right):

https://codereview.chromium.org/1155983003/diff/20001/LayoutTests/fast/css/qu...
LayoutTests/fast/css/quotes-parsing.html:13: assert_equals(div.style.quotes,
"\"a\" \"b\"");
On 2015/05/27 09:11:37, Timothy Loh wrote:
> If you use a single-quoted string, you don't need the backslashes, i.e. '"a"
> "b"'

Done.

https://codereview.chromium.org/1155983003/diff/20001/LayoutTests/fast/css/qu...
LayoutTests/fast/css/quotes-parsing.html:14: }, "Invalid strings for quotes
property do not parse and valid strings should be serialized by space
separator");
On 2015/05/27 09:11:37, Timothy Loh wrote:
> Can you pull out the added test into a separate test() call?

Done.

[Timothy Loh, 2015-05-27 09:45:55]

lgtm

https://codereview.chromium.org/1155983003/diff/40001/LayoutTests/fast/css/qu...
File LayoutTests/fast/css/quotes-parsing.html (right):

https://codereview.chromium.org/1155983003/diff/40001/LayoutTests/fast/css/qu...
LayoutTests/fast/css/quotes-parsing.html:15: div.style.quotes = '"a" "b"';
extra indentation here?

[ramya.v, 2015-05-27 09:51:48]

Sorry for the petty mistake. Made indentation proper now.

https://codereview.chromium.org/1155983003/diff/40001/LayoutTests/fast/css/qu...
File LayoutTests/fast/css/quotes-parsing.html (right):

https://codereview.chromium.org/1155983003/diff/40001/LayoutTests/fast/css/qu...
LayoutTests/fast/css/quotes-parsing.html:15: div.style.quotes = '"a" "b"';
On 2015/05/27 09:45:55, Timothy Loh wrote:
> extra indentation here?

Done.

[ramya.v, 2015-05-27 10:03:01]

The CQ bit was checked by ramya.v@samsung.com

[ramya.v, 2015-05-27 10:03:01]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1155983003/#ps60001
(title: "Formatted indentation correctly")

[commit-bot: I haz the power, 2015-05-27 10:03:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155983003/60001

[commit-bot: I haz the power, 2015-05-27 11:40:15]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195973