LayoutTests/fast/css/quotes-parsing.html - Issue 1155983003: 'quotes' property is serialized wrongly on inline styles

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/quotes-parsing.html

Issue 1155983003: 'quotes' property is serialized wrongly on inline styles (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added test case Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <script src="../../resources/testharness.js"></script>	1 <script src="../../resources/testharness.js"></script>

2 <script src="../../resources/testharnessreport.js"></script>	2 <script src="../../resources/testharnessreport.js"></script>

3 <div id="div"></div>	3 <div id="div"></div>

4 <script>	4 <script>

5 test(function(){	5 test(function(){

6 div.style.quotes = "red";	6 div.style.quotes = "red";

7 assert_equals(div.style.quotes, "");	7 assert_equals(div.style.quotes, "");

8 div.style.quotes = '"a"';	8 div.style.quotes = '"a"';

9 assert_equals(div.style.quotes, "");	9 assert_equals(div.style.quotes, "");

10 div.style.quotes = '"a" "b" cake';	10 div.style.quotes = '"a" "b" cake';

11 assert_equals(div.style.quotes, "");	11 assert_equals(div.style.quotes, "");

12 }, "Invalid strings for quotes property do not parse");	12 div.style.quotes = '"a" "b"';

	13 assert_equals(div.style.quotes, "\"a\" \"b\"");
	Timothy Loh 2015/05/27 09:11:37 If you use a single-quoted string, you don't need If you use a single-quoted string, you don't need the backslashes, i.e. '"a" "b"' ramya.v 2015/05/27 09:22:15 Done. Show quoted text On 2015/05/27 09:11:37, Timothy Loh wrote: > If you use a single-quoted string, you don't need the backslashes, i.e. '"a" > "b"' Done.
	14 }, "Invalid strings for quotes property do not parse and valid strings should be serialized by space separator");
	Timothy Loh 2015/05/27 09:11:37 Can you pull out the added test into a separate te Can you pull out the added test into a separate test() call? ramya.v 2015/05/27 09:22:15 Done. Show quoted text On 2015/05/27 09:11:37, Timothy Loh wrote: > Can you pull out the added test into a separate test() call? Done.
13 </script>	15 </script>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »