Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 1155983003: 'quotes' property is serialized wrongly on inline styles (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Formatted indentation correctly Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/css/quotes-parsing.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
9 * Copyright (C) 2012 Intel Corporation. All rights reserved. 9 * Copyright (C) 2012 Intel Corporation. All rights reserved.
10 * 10 *
(...skipping 2072 matching lines...) Expand 10 before | Expand all | Expand 10 after
2083 } 2083 }
2084 return None; 2084 return None;
2085 default: 2085 default:
2086 return None; 2086 return None;
2087 } 2087 }
2088 } 2088 }
2089 2089
2090 // [ <string> <string> ]+ | none, but none is handled in parseValue 2090 // [ <string> <string> ]+ | none, but none is handled in parseValue
2091 PassRefPtrWillBeRawPtr<CSSValue> CSSPropertyParser::parseQuotes() 2091 PassRefPtrWillBeRawPtr<CSSValue> CSSPropertyParser::parseQuotes()
2092 { 2092 {
2093 RefPtrWillBeRawPtr<CSSValueList> values = CSSValueList::createCommaSeparated (); 2093 RefPtrWillBeRawPtr<CSSValueList> values = CSSValueList::createSpaceSeparated ();
2094 while (CSSParserValue* val = m_valueList->current()) { 2094 while (CSSParserValue* val = m_valueList->current()) {
2095 RefPtrWillBeRawPtr<CSSValue> parsedValue = nullptr; 2095 RefPtrWillBeRawPtr<CSSValue> parsedValue = nullptr;
2096 if (val->unit != CSSPrimitiveValue::CSS_STRING) 2096 if (val->unit != CSSPrimitiveValue::CSS_STRING)
2097 return nullptr; 2097 return nullptr;
2098 parsedValue = createPrimitiveStringValue(val); 2098 parsedValue = createPrimitiveStringValue(val);
2099 values->append(parsedValue.release()); 2099 values->append(parsedValue.release());
2100 m_valueList->next(); 2100 m_valueList->next();
2101 } 2101 }
2102 if (values->length() && values->length() % 2 == 0) 2102 if (values->length() && values->length() % 2 == 0)
2103 return values.release(); 2103 return values.release();
(...skipping 6296 matching lines...) Expand 10 before | Expand all | Expand 10 after
8400 } 8400 }
8401 } 8401 }
8402 8402
8403 if (!list->length()) 8403 if (!list->length())
8404 return nullptr; 8404 return nullptr;
8405 8405
8406 return list.release(); 8406 return list.release();
8407 } 8407 }
8408 8408
8409 } // namespace blink 8409 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/fast/css/quotes-parsing.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698