Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1155683004: [turbofan] Connect loops to end via Terminate during graph building. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Connect loops to end via Terminate during graph building. This way we don't need to connect (potentially) non-terminating loops later during control reduction, which saves one forward pass over the control graph. Long term we will move the trimming functionality of the control reducer to the GraphReducer, and get rid of the Finish method again. As a bonus, this change also properly rewires Terminate, Throw and Deoptimize during inlining. R=mstarzinger@chromium.org Committed: https://crrev.com/f6fb5eb19796736cb414840652c9868693a5775a Cr-Commit-Position: refs/heads/master@{#28625}

Patch Set 1 #

Patch Set 2 : Also remove redundant EffectPhis now. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -220 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/control-reducer.cc View 1 3 chunks +5 lines, -142 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +7 lines, -1 line 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/control-reducer-unittest.cc View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-26 11:49:54 UTC) #1
Benedikt Meurer
Michi: This is the Terminate thing we've looked into. Please take a look. Ben: Please ...
5 years, 7 months ago (2015-05-26 11:50:52 UTC) #3
titzer
lgtm
5 years, 7 months ago (2015-05-26 11:55:41 UTC) #4
Michael Starzinger
LGTM.
5 years, 7 months ago (2015-05-26 12:11:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155683004/20001
5 years, 7 months ago (2015-05-26 12:11:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-26 12:18:02 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 12:18:19 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6fb5eb19796736cb414840652c9868693a5775a
Cr-Commit-Position: refs/heads/master@{#28625}

Powered by Google App Engine
This is Rietveld 408576698