src/compiler/common-operator.cc - Issue 1155683004: [turbofan] Connect loops to end via Terminate during graph building.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/common-operator.cc

Issue 1155683004: [turbofan] Connect loops to end via Terminate during graph building. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Also remove redundant EffectPhis now. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/common-operator.cc

diff --git a/src/compiler/common-operator.cc b/src/compiler/common-operator.cc

index 239382eb07cc220c7acbaaf33967e36bdad67fba..874ad29cef7d9efa7129fcd92e55333755159a1a 100644

--- a/src/compiler/common-operator.cc

+++ b/src/compiler/common-operator.cc

@@ -110,7 +110,7 @@ std::ostream& operator<<(std::ostream& os, ParameterInfo const& i) {

V(Throw, Operator::kKontrol, 1, 1, 1, 0, 0, 1) \

V(Deoptimize, Operator::kNoThrow, 1, 1, 1, 0, 0, 1) \

V(Return, Operator::kNoThrow, 1, 1, 1, 0, 0, 1) \

- V(Terminate, Operator::kNoThrow, 0, 1, 1, 0, 0, 1) \

+ V(Terminate, Operator::kKontrol, 0, 1, 1, 0, 0, 1) \

V(OsrNormalEntry, Operator::kFoldable, 0, 1, 1, 0, 1, 1) \

V(OsrLoopEntry, Operator::kFoldable, 0, 1, 1, 0, 1, 1)

« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/compiler/control-reducer.cc » ('j') | no next file with comments »