Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1155553006: Revert of cc: Fix size_t to int truncations in layers/ output/ playback/ quads/ (Closed)

Created:
5 years, 6 months ago by vmpstr
Modified:
5 years, 6 months ago
Reviewers:
danakj, jschuh, Mike West
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Fix size_t to int truncations in layers/ output/ playback/ quads/ (patchset #12 id:260001 of https://codereview.chromium.org/1158433010/) Reason for revert: Broke windows build. http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/2919 Original issue's description: > cc: Fix size_t to int truncations in layers/ output/ playback/ quads/ > > This patch fixes size_t to int truncations in layers/, output/, > playback/, and quads/ directories in cc/. > > R=danakj > BUG=167187 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/0d5963315aa03e6ebb20351f13d3d517ca14d816 > Cr-Commit-Position: refs/heads/master@{#333153} TBR=danakj@chromium.org,mkwst@chromium.org,jschuh@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=167187 Committed: https://crrev.com/02b4fa89a8356d429d19526f072bd0fab8df96a9 Cr-Commit-Position: refs/heads/master@{#333167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -88 lines) Patch
M cc/layers/delegated_renderer_layer_impl.h View 1 chunk +1 line, -3 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl.cc View 7 chunks +9 lines, -14 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl_unittest.cc View 5 chunks +17 lines, -17 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M cc/layers/layer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/layers/layer.cc View 5 chunks +18 lines, -12 lines 0 comments Download
M cc/layers/layer_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/layers/layer_iterator.h View 2 chunks +7 lines, -9 lines 0 comments Download
M cc/output/direct_renderer.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +1 line, -4 lines 0 comments Download
M cc/playback/display_item_list.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/quads/render_pass.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/render_pass.cc View 6 chunks +9 lines, -6 lines 0 comments Download
M cc/quads/render_pass_draw_quad.cc View 3 chunks +4 lines, -1 line 0 comments Download
M cc/quads/render_pass_id.h View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/quads/render_pass_id.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/surfaces/surface_aggregator_test_helpers.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/common/cc_messages.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
vmpstr
Created Revert of cc: Fix size_t to int truncations in layers/ output/ playback/ quads/
5 years, 6 months ago (2015-06-05 23:01:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155553006/1
5 years, 6 months ago (2015-06-05 23:02:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 23:09:25 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 23:10:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02b4fa89a8356d429d19526f072bd0fab8df96a9
Cr-Commit-Position: refs/heads/master@{#333167}

Powered by Google App Engine
This is Rietveld 408576698