cc/output/gl_renderer.cc - Issue 1155553006: Revert of cc: Fix size_t to int truncations in layers/ output/ playback/ quads/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/gl_renderer.cc

Issue 1155553006: Revert of cc: Fix size_t to int truncations in layers/ output/ playback/ quads/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/gl_renderer.cc

diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc

index bce832522bf614286134a4e25af2a2444bf0dd49..faf6bbb0119b0ebbcafb3f9aa5b73b3e44fd3a02 100644

--- a/cc/output/gl_renderer.cc

+++ b/cc/output/gl_renderer.cc

@@ -2239,11 +2239,8 @@

static_cast<int>(draw_cache_.vertex_opacity_data.size()),

static_cast<float*>(&draw_cache_.vertex_opacity_data.front()));

- DCHECK_LE(draw_cache_.matrix_data.size(),

- static_cast<size_t>(std::numeric_limits<int>::max()) / 6u);

// Draw the quads!

- gl_->DrawElements(GL_TRIANGLES,

- 6 * static_cast<int>(draw_cache_.matrix_data.size()),

+ gl_->DrawElements(GL_TRIANGLES, 6 * draw_cache_.matrix_data.size(),

GL_UNSIGNED_SHORT, 0);

// Clear the cache.

« no previous file with comments | « cc/output/direct_renderer.cc ('k') | cc/playback/display_item_list.cc » ('j') | no next file with comments »