Issue 1155453006: Files.app: Store thumbnailUrl from external metadata provider only when it is requested or gotten.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1155453006: Files.app: Store thumbnailUrl from external metadata provider only when it is requested or gotten. (Closed)

Created:
5 years, 6 months ago by fukino

Modified:
5 years, 6 months ago

Reviewers:
hirono

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2403

Target Ref:
refs/pending/branch-heads/2403

Project:
chromium

Visibility:
Public.

More Reviews

Description

Files.app: Store thumbnailUrl from external metadata provider only when it is requested or gotten. Storing 'undefined' value when the thumbnail url is not requested will result in missing thumbnails on FSP volumes. This CL fixes the issue by storing metadata only when it is requested or gotten without request. We should apply the same treatment for all properties, but this CL do it only for thumbnailUrl to minimize the impact and prepare for merge. For more context, please see the comments in http://crrev.com/1158463004 BUG=489595, 494910 TEST=Install TED talks extension, switch to grid view, and check thumbnails exist. TBR=hirono@chromium.org Review URL: https://codereview.chromium.org/1144393007 Cr-Commit-Position: refs/heads/master@{#332532} (cherry picked from commit 60cd0f79fd0f3065c2f5a1f44e19d99a09fd8888) Committed: https://chromium.googlesource.com/chromium/src/+/884940495d3c6900db4ef6cb5a5e783e4e1e2207

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js	View		3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

fukino

5 years, 6 months ago (2015-06-04 02:33:44 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
884940495d3c6900db4ef6cb5a5e783e4e1e2207 (presubmit successful).

Expand Messages | Collapse Messages