Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js

Issue 1155453006: Files.app: Store thumbnailUrl from external metadata provider only when it is requested or gotten. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2403
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js
diff --git a/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js b/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js
index 30494454e78c89a7a9a8b174a4b000ac89253259..5b8362071bb94e0c6710a66a90f91c29f70a631b 100644
--- a/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js
+++ b/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js
@@ -62,7 +62,7 @@ ExternalMetadataProvider.prototype.get = function(requests) {
Object.keys(nameMap),
function(results) {
if (!chrome.runtime.lastError)
- fulfill(this.convertResults_(requests, results));
+ fulfill(this.convertResults_(requests, nameMap, results));
else
fulfill(requests.map(function() { return new MetadataItem(); }));
}.bind(this));
@@ -71,11 +71,12 @@ ExternalMetadataProvider.prototype.get = function(requests) {
/**
* @param {!Array<!MetadataRequest>} requests
+ * @param {!Object<boolean>} nameMap
* @param {!Array<!EntryProperties>} propertiesList
* @return {!Array<!MetadataItem>}
*/
ExternalMetadataProvider.prototype.convertResults_ =
- function(requests, propertiesList) {
+ function(requests, nameMap, propertiesList) {
var results = [];
for (var i = 0; i < propertiesList.length; i++) {
var properties = propertiesList[i];
@@ -97,7 +98,8 @@ ExternalMetadataProvider.prototype.convertResults_ =
item.shared = properties.shared;
item.sharedWithMe = properties.sharedWithMe;
item.size = requests[i].entry.isFile ? (properties.size || 0) : -1;
- item.thumbnailUrl = properties.thumbnailUrl;
+ if (properties.thumbnailUrl || nameMap['thumbnailUrl'])
+ item.thumbnailUrl = properties.thumbnailUrl;
results.push(item);
}
return results;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698