Chromium Code Reviews

Issue 1144393007: Files.app: Store thumbnailUrl from external metadata provider only when it is requested or gotten. (Closed)

Created:
5 years, 6 months ago by fukino
Modified:
5 years, 6 months ago
Reviewers:
mtomasz, hirono
CC:
mtomasz, chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Store thumbnailUrl from external metadata provider only when it is requested or gotten. Storing 'undefined' value when the thumbnail url is not requested will result in missing thumbnails on FSP volumes. This CL fixes the issue by storing metadata only when it is requested or gotten without request. We should apply the same treatment for all properties, but this CL do it only for thumbnailUrl to minimize the impact and prepare for merge. For more context, please see the comments in http://crrev.com/1158463004 BUG=489595, 494910 TEST=Install TED talks extension, switch to grid view, and check thumbnails exist. Committed: https://crrev.com/60cd0f79fd0f3065c2f5a1f44e19d99a09fd8888 Cr-Commit-Position: refs/heads/master@{#332532}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+5 lines, -3 lines)
M ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js View 3 chunks +5 lines, -3 lines 0 comments

Messages

Total messages: 10 (3 generated)
fukino
hirono@, could you take a look? Thanks!
5 years, 6 months ago (2015-06-02 05:50:51 UTC) #2
mtomasz
Thanks for fixing it! lgtm from me, but please wait for @hirono's lgtm who knows ...
5 years, 6 months ago (2015-06-02 06:13:02 UTC) #4
hirono
lgtm. Thank you for fixing this!
5 years, 6 months ago (2015-06-02 17:26:12 UTC) #5
fukino
Thanks!
5 years, 6 months ago (2015-06-03 01:29:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144393007/1
5 years, 6 months ago (2015-06-03 01:31:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 03:18:39 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 03:20:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60cd0f79fd0f3065c2f5a1f44e19d99a09fd8888
Cr-Commit-Position: refs/heads/master@{#332532}

Powered by Google App Engine