Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6114)

Unified Diff: chrome/browser/notifications/profile_notification.cc

Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/profile_notification.cc
diff --git a/chrome/browser/notifications/profile_notification.cc b/chrome/browser/notifications/profile_notification.cc
index 745820a2ee5862b857b3f778540eab4c2b540b5a..9e9ef3afc7134b787da9847629c52cbde34df6b2 100644
--- a/chrome/browser/notifications/profile_notification.cc
+++ b/chrome/browser/notifications/profile_notification.cc
@@ -18,16 +18,13 @@ std::string ProfileNotification::GetProfileNotificationId(
delegate_id.c_str());
}
-ProfileNotification::ProfileNotification(
- Profile* profile,
- const Notification& notification)
- : profile_(profile),
+ProfileNotification::ProfileNotification(ProfileID profile,
dewittj 2015/05/27 18:22:39 nit: s/profile/profile_id/
Deepak 2015/05/28 05:37:08 Done.
+ const Notification& notification)
+ : profile_id_(profile),
notification_(
// Uses Notification's copy constructor to assign the message center
// id, which should be unique for every profile + Notification pair.
- GetProfileNotificationId(
- notification.delegate_id(),
- NotificationUIManager::GetProfileID(profile)),
+ GetProfileNotificationId(notification.delegate_id(), profile),
notification) {
DCHECK(profile);
#if defined(OS_CHROMEOS)

Powered by Google App Engine
This is Rietveld 408576698