chrome/browser/notifications/profile_notification.h - Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/profile_notification.h

Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/notification_ui_manager.h ('K') | « chrome/browser/notifications/notification_ui_manager_android.cc ('k') | chrome/browser/notifications/profile_notification.cc » ('j') | chrome/browser/notifications/profile_notification.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/profile_notification.h

diff --git a/chrome/browser/notifications/profile_notification.h b/chrome/browser/notifications/profile_notification.h

index 13952333e2ec142ee3496ea563793f6974cc4eba..3472ffd3e748669e529334e6c32e437632df8dfd 100644

--- a/chrome/browser/notifications/profile_notification.h

+++ b/chrome/browser/notifications/profile_notification.h

@@ -21,15 +21,15 @@ class ProfileNotification {

static std::string GetProfileNotificationId(const std::string& delegate_id,

ProfileID profile_id);

- ProfileNotification(Profile* profile, const Notification& notification);

+ ProfileNotification(ProfileID profile_id, const Notification& notification);

~ProfileNotification();

- Profile* profile() const { return profile_; }

+ ProfileID profile_id() const { return profile_id_; }

const Notification& notification() const { return notification_; }

private:

- // Weak, guaranteed not to be used after profile removal by parent class.

- Profile* profile_;

+ // Used for equality comparision in notification maps.

+ ProfileID profile_id_;

Notification notification_;

};