Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal…

chrome/browser/notifications/notification_ui_manager.h

Index: chrome/browser/notifications/notification_ui_manager.h
diff --git a/chrome/browser/notifications/notification_ui_manager.h b/chrome/browser/notifications/notification_ui_manager.h
index 49d0ed91f95cfd81e10ff236d31815c6eaaddeb8..64c06a3d4ad717dad823c3c063919061f351b06e 100644
--- a/chrome/browser/notifications/notification_ui_manager.h
+++ b/chrome/browser/notifications/notification_ui_manager.h
@@ -67,17 +67,13 @@ class NotificationUIManager {
                           ProfileID profile_id) = 0;
 
   // Returns the set of all delegate IDs for notifications from the passed
-  // |profile| and |source|.
-  // TODO(peter): Change Profile* to ProfileID to clarify that the profile
-  // should not be used for making any calls, as it might be dead.
+  // |profile_id| and |source|.
   virtual std::set<std::string> GetAllIdsByProfileAndSourceOrigin(
-      Profile* profile,
+      ProfileID profile_id,
       const GURL& source) = 0;
 
-  // Returns the set of all delegate IDs for notifications from |profile|.
-  // TODO(peter): Change Profile* to ProfileID to clarify that the profile
-  // should not be used for making any calls, as it might be dead.
-  virtual std::set<std::string> GetAllIdsByProfile(Profile* profile) = 0;
+  // Returns the set of all delegate IDs for notifications from |profile_id|.
+  virtual std::set<std::string> GetAllIdsByProfile(ProfileID profile_id) = 0;

[dewittj, 2015/05/27 18:22:39]

I think there is at least one callsite of this function
(platform_notification_service_impl.cc) that needs to use GetProfileId now.

[Deepak, 2015/05/28 05:37:08]

Done.

 
   // Removes notifications matching the |source_origin| (which could be an
   // extension ID). Returns true if anything was removed.