chrome/browser/extensions/api/notifications/notifications_api.cc - Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/notifications/notifications_api.cc

Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/notification/download_notification_item_unittest.cc ('k') | chrome/browser/notifications/message_center_notification_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/notifications/notifications_api.cc

diff --git a/chrome/browser/extensions/api/notifications/notifications_api.cc b/chrome/browser/extensions/api/notifications/notifications_api.cc

index ac1b6be125ff833c604f6616fbb6e70b6219737d..9caba50bb81bea6b9eac7d4f61e591a6da3e0cff 100644

--- a/chrome/browser/extensions/api/notifications/notifications_api.cc

+++ b/chrome/browser/extensions/api/notifications/notifications_api.cc

@@ -624,7 +624,7 @@ bool NotificationsGetAllFunction::RunNotificationsApi() {

g_browser_process->notification_ui_manager();

std::set<std::string> notification_ids =

notification_ui_manager->GetAllIdsByProfileAndSourceOrigin(

- GetProfile(), extension_->url());

+ NotificationUIManager::GetProfileID(GetProfile()), extension_->url());

scoped_ptr<base::DictionaryValue> result(new base::DictionaryValue());