chrome/browser/download/notification/download_notification_item_unittest.cc - Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/notification/download_notification_item_unittest.cc

Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/notification/download_notification_item_unittest.cc

diff --git a/chrome/browser/download/notification/download_notification_item_unittest.cc b/chrome/browser/download/notification/download_notification_item_unittest.cc

index 9939f14acad69814f08c3ec6e2ae896f9ddbce3c..4248ca81ac9e5e04fa083e28e61e52dc97a87dcf 100644

--- a/chrome/browser/download/notification/download_notification_item_unittest.cc

+++ b/chrome/browser/download/notification/download_notification_item_unittest.cc

@@ -126,7 +126,7 @@ class DownloadNotificationItemTest : public testing::Test {

size_t NotificationCount() const {

return ui_manager_

->GetAllIdsByProfileAndSourceOrigin(

- profile_,

+ NotificationUIManager::GetProfileID(profile_),

GURL(DownloadNotificationItem::kDownloadNotificationOrigin))

.size();

}

« no previous file with comments | « no previous file | chrome/browser/extensions/api/notifications/notifications_api.cc » ('j') | no next file with comments »