chrome/browser/notifications/message_center_notification_manager.h - Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_notification_manager.h

Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/notifications/notifications_api.cc ('k') | chrome/browser/notifications/message_center_notification_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/message_center_notification_manager.h

diff --git a/chrome/browser/notifications/message_center_notification_manager.h b/chrome/browser/notifications/message_center_notification_manager.h

index a5a2149c89154d23ec5806f8f9104b5167649cea..64fc7c8e40911031e273dc7caafddf84bfd11eb0 100644

--- a/chrome/browser/notifications/message_center_notification_manager.h

+++ b/chrome/browser/notifications/message_center_notification_manager.h

@@ -59,9 +59,9 @@ class MessageCenterNotificationManager

bool CancelById(const std::string& delegate_id,

ProfileID profile_id) override;

std::set<std::string> GetAllIdsByProfileAndSourceOrigin(

- Profile* profile,

+ ProfileID profile_id,

const GURL& source) override;

- std::set<std::string> GetAllIdsByProfile(Profile* profile) override;

+ std::set<std::string> GetAllIdsByProfile(ProfileID profile_id) override;

bool CancelAllBySourceOrigin(const GURL& source_origin) override;

bool CancelAllByProfile(ProfileID profile_id) override;

void CancelAll() override;

@@ -96,7 +96,8 @@ class MessageCenterNotificationManager

private:

// Adds |profile_notification| to an alternative provider extension or app.

void AddNotificationToAlternateProvider(

- ProfileNotification* profile_notification,

+ const Notification& notification,

+ Profile* profile,

const std::string& extension_id) const;

FRIEND_TEST_ALL_PREFIXES(message_center::WebNotificationTrayTest,