Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1155303008: Allow directories for GN data lists. (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@path
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow directories for GN data lists. Allow the members of the "data" variable in GN targets to be either files or directories. This means storing them as strings rather than SourceFile objects, and rebasing as necessary. The documentation is updated accordingly. Added a move constructor for OutputFile. While move constructors are discouraged, OutputFile is just a wrapper around a std::string for type checking, and I think this is in the spirit of things. Committed: https://crrev.com/e903c0f86b126b25fedaa0439230da1576aeb476 Cr-Commit-Position: refs/heads/master@{#332712}

Patch Set 1 #

Total comments: 1

Patch Set 2 : add dir test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -37 lines) Patch
M tools/gn/command_refs.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/output_file.h View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/output_file.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M tools/gn/runtime_deps.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M tools/gn/runtime_deps_unittest.cc View 1 8 chunks +11 lines, -11 lines 0 comments Download
M tools/gn/target.h View 2 chunks +6 lines, -4 lines 0 comments Download
M tools/gn/target_generator.cc View 1 chunk +33 lines, -5 lines 0 comments Download
M tools/gn/variables.cc View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
brettw
5 years, 6 months ago (2015-06-03 21:58:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155303008/1
5 years, 6 months ago (2015-06-03 22:00:05 UTC) #4
scottmg
https://codereview.chromium.org/1155303008/diff/1/tools/gn/runtime_deps_unittest.cc File tools/gn/runtime_deps_unittest.cc (right): https://codereview.chromium.org/1155303008/diff/1/tools/gn/runtime_deps_unittest.cc#newcode194 tools/gn/runtime_deps_unittest.cc:194: dep_copy.data().push_back("//dep_copy.data"); should there be a test for directories here ...
5 years, 6 months ago (2015-06-03 22:11:31 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-03 22:16:42 UTC) #7
brettw
Good idea, done.
5 years, 6 months ago (2015-06-03 22:18:18 UTC) #8
scottmg
lgtm
5 years, 6 months ago (2015-06-03 22:19:09 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155303008/20001
5 years, 6 months ago (2015-06-03 22:20:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155303008/20001
5 years, 6 months ago (2015-06-03 22:22:05 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-03 22:40:28 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e903c0f86b126b25fedaa0439230da1576aeb476 Cr-Commit-Position: refs/heads/master@{#332712}
5 years, 6 months ago (2015-06-03 22:41:12 UTC) #16
Dirk Pranke
5 years, 6 months ago (2015-06-03 23:10:40 UTC) #17
Message was sent while issue was closed.
I have confirmed that this fixes the issue w/ isolates.

Powered by Google App Engine
This is Rietveld 408576698