Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: tools/gn/target.h

Issue 1155303008: Allow directories for GN data lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@path
Patch Set: add dir test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/runtime_deps_unittest.cc ('k') | tools/gn/target_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target.h
diff --git a/tools/gn/target.h b/tools/gn/target.h
index 081f81ee2c64ab7712ed3c71da1898edf8fc0a78..00500489923ddec832ede0ea067eb9f0183b5b83 100644
--- a/tools/gn/target.h
+++ b/tools/gn/target.h
@@ -120,9 +120,11 @@ class Target : public Item {
const FileList& inputs() const { return inputs_; }
FileList& inputs() { return inputs_; }
- // Runtime dependencies.
- const FileList& data() const { return data_; }
- FileList& data() { return data_; }
+ // Runtime dependencies. These are "file-like things" that can either be
+ // directories or files. They do not need to exist, these are just passed as
+ // runtime dependencies to external test systems as necessary.
+ const std::vector<std::string>& data() const { return data_; }
+ std::vector<std::string>& data() { return data_; }
// Returns true if targets depending on this one should have an order
// dependency.
@@ -270,7 +272,7 @@ class Target : public Item {
bool complete_static_lib_;
bool testonly_;
FileList inputs_;
- FileList data_;
+ std::vector<std::string> data_;
LabelTargetVector private_deps_;
LabelTargetVector public_deps_;
« no previous file with comments | « tools/gn/runtime_deps_unittest.cc ('k') | tools/gn/target_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698