tools/gn/command_refs.cc - Issue 1155303008: Allow directories for GN data lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/command_refs.cc

Issue 1155303008: Allow directories for GN data lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@path

Patch Set: add dir test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/command_refs.cc

diff --git a/tools/gn/command_refs.cc b/tools/gn/command_refs.cc

index 57ea82477342c892dd8a3a70f02e1d145ef473a5..9c89114668d96bdf33acbaeca65c41f266ae0136 100644

--- a/tools/gn/command_refs.cc

+++ b/tools/gn/command_refs.cc

@@ -138,7 +138,7 @@ bool TargetContainsFile(const Target* target, const SourceFile& file) {

return true;

}

for (const auto& cur_file : target->data()) {

- if (cur_file == file)

+ if (cur_file == file.value())

return true;

}

return false;

« no previous file with comments | « no previous file | tools/gn/output_file.h » ('j') | no next file with comments »