Issue 1155243010: clang/win/gn: Pass -msse flags to clang-cl.exe for skia

Issue 1155243010: clang/win/gn: Pass -msse flags to clang-cl.exe for skia (Closed)

Created:
5 years, 6 months ago by Nico

Modified:
5 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

clang/win/gn: Pass -msse flags to clang-cl.exe for skia This is a port of https://codereview.chromium.org/475273002 to gn. Also add a comment that explains that the skia_opts target in the GN build isn't correct. BUG=491209, 82385, 496512 Committed: https://crrev.com/bb9d67e7b77484c4fa2a653c0f89b60cc3f894de Cr-Commit-Position: refs/heads/master@{#333091}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	skia/BUILD.gn	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 8 (2 generated)

Nico

(See also https://codereview.chromium.org/1166693006/, a very similar change for libvpx)

5 years, 6 months ago (2015-06-05 00:08:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155243010/1

5 years, 6 months ago (2015-06-05 17:41:07 UTC) #6

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 18:03:50 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bb9d67e7b77484c4fa2a653c0f89b60cc3f894de
Cr-Commit-Position: refs/heads/master@{#333091}