Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 475273002: Attempt to let skia's SSE files build with clang-cl. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
Reid Kleckner
CC:
chromium-reviews, hans, mtklein
Project:
chromium
Visibility:
Public.

Description

Attempt to let skia's SSE files build with clang-cl. cl.exe can use intrinsics (like e.g. _mm_cvtsi128_si32()) even if arch targetted by the compiler doesn't support the SSE level needed by the intrinsic. clang (and gcc) can't do this, because it converts intrinsics into general LLVM operations, and the LLVM bitcode is then translated back into assembly later on, based on the target arch. So explicitly enable SSSE3 and SSE4 when using clang-cl, so that the intrinsics compile. (It's unfortunate that clang-cl deviates fairly heavily from cl in this regard. But this is very difficult to change, and it's the only larger deviation so far.) BUG=82385 R=rnk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289735

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M skia/skia_library_opts.gyp View 2 chunks +14 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Nico
6 years, 4 months ago (2014-08-15 00:33:23 UTC) #1
Reid Kleckner
lgtm Thanks, I started this bug I got stuck somewhere in libvpx because their gyp ...
6 years, 4 months ago (2014-08-15 00:40:03 UTC) #2
Nico
6 years, 4 months ago (2014-08-15 00:45:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 289735 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698