Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: skia/BUILD.gn

Issue 1155243010: clang/win/gn: Pass -msse flags to clang-cl.exe for skia (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/BUILD.gn
diff --git a/skia/BUILD.gn b/skia/BUILD.gn
index 29ad87940729d4859ad9bb63d363df1f27f56a21..5fedacf3b149bcb209b92dcc99d4ebb7bb833ca4 100644
--- a/skia/BUILD.gn
+++ b/skia/BUILD.gn
@@ -545,6 +545,7 @@ component("skia") {
}
# Separated out so it can be compiled with different flags for SSE.
+# TODO(GYP): This is wrong, it needs one target per arch http://crbug.com/496512
source_set("skia_opts") {
cflags = []
defines = []
@@ -558,9 +559,10 @@ source_set("skia_opts") {
"ext/convolver_SSE2.h",
]
- if (is_linux || is_mac) {
+ if (!is_win || is_clang) {
cflags += [ "-msse4.1" ]
- } else if (is_win) {
+ }
+ if (is_win) {
defines += [ "SK_CPU_SSE_LEVEL=41" ]
}
} else if (current_cpu == "arm") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698