Chromium Code Reviews| Index: components/omnibox/autocomplete_result.h |
| diff --git a/components/omnibox/autocomplete_result.h b/components/omnibox/autocomplete_result.h |
| index 6d8d746f986c90f779780ce099161e6e04f30a7c..4b8900a0648cfb7b80265300eca4fbb9fec61eec 100644 |
| --- a/components/omnibox/autocomplete_result.h |
| +++ b/components/omnibox/autocomplete_result.h |
| @@ -100,36 +100,6 @@ class AutocompleteResult { |
| // end() if there is no default match. |
| const_iterator default_match() const { return default_match_; } |
| - // Returns true if the top match is a verbatim search or URL match (see |
| - // IsVerbatimType() in autocomplete_match.h), and the next match is not also |
| - // some kind of verbatim match. In this case, the top match will be hidden, |
| - // and nothing in the dropdown will appear selected by default; hitting enter |
| - // will navigate to the (hidden) default match, while pressing the down arrow |
| - // key will select the first visible match, which is actually the second match |
| - // in the result set. |
| - // |
| - // Hiding the top match in these cases is possible because users should |
| - // already know what will happen on hitting enter from the omnibox text |
| - // itself, without needing to see the same text appear again, selected, just |
| - // below their typing. Instead, by hiding the verbatim match, there is one |
| - // less line to skip over in order to visually scan downwards to see other |
| - // suggested matches. This makes it more likely that users will see and |
| - // select useful non-verbatim matches. (Note that hiding the verbatim match |
| - // this way is similar to how most other browsers' address bars behave.) |
| - // |
| - // We avoid hiding when the top two matches are both verbatim in order to |
| - // avoid potential confusion if a user were to see the second match just below |
| - // their typing and assume it would be the default action. |
| - // |
| - // Note that if the top match should be hidden and it is the only match, |
| - // the dropdown should be closed. |
| - bool ShouldHideTopMatch() const; |
| - |
| - // Returns true if the top match is a verbatim search or URL match (see |
| - // IsVerbatimType() in autocomplete_match.h), and the next match is not also |
| - // some kind of verbatim match. |
| - bool TopMatchIsStandaloneVerbatimMatch() const; |
|
groby-ooo-7-16
2015/05/27 19:25:51
According to https://codereview.chromium.org/69703
groby-ooo-7-16
2015/05/27 20:38:35
Just chatted with kmadhusu, the owner of the CL in
kmadhusu
2015/05/28 01:55:09
You can remove this. This was a part of our previo
dschuyler
2015/05/28 18:58:06
Acknowledged.
dschuyler
2015/05/28 18:58:06
Acknowledged.
dschuyler
2015/05/28 18:58:06
Done.
|
| - |
| const GURL& alternate_nav_url() const { return alternate_nav_url_; } |
| // Clears the matches for this result set. |