Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: components/omnibox/autocomplete_result.cc

Issue 1154063003: removing ShouldHideTopMatch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Deprecated event proto Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/autocomplete_result.cc
diff --git a/components/omnibox/autocomplete_result.cc b/components/omnibox/autocomplete_result.cc
index f2d171f71353ff9eecb46eccfab2ca3761119898..84d68009380151ff94aed7033e6884ed0788e262 100644
--- a/components/omnibox/autocomplete_result.cc
+++ b/components/omnibox/autocomplete_result.cc
@@ -294,25 +294,6 @@ AutocompleteMatch* AutocompleteResult::match_at(size_t index) {
return &matches_[index];
}
-bool AutocompleteResult::ShouldHideTopMatch() const {
- return chrome::ShouldHideTopVerbatimMatch() &&
groby-ooo-7-16 2015/05/27 19:25:51 If ShouldHideTopMatch goes, ShouldHideTopVerbatimM
dschuyler 2015/05/28 18:58:06 Thanks! Done.
- TopMatchIsStandaloneVerbatimMatch();
-}
-
-bool AutocompleteResult::TopMatchIsStandaloneVerbatimMatch() const {
- if (empty() || !match_at(0).IsVerbatimType())
- return false;
-
- // Skip any copied matches, under the assumption that they'll be expired and
- // disappear. We don't want this disappearance to cause the visibility of the
- // top match to change.
- for (const_iterator i(begin() + 1); i != end(); ++i) {
- if (!i->from_previous)
- return !i->IsVerbatimType();
- }
- return true;
-}
-
void AutocompleteResult::Reset() {
matches_.clear();
default_match_ = end();

Powered by Google App Engine
This is Rietveld 408576698