components/metrics/proto/omnibox_event.proto - Issue 1154063003: removing ShouldHideTopMatch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/proto/omnibox_event.proto

Issue 1154063003: removing ShouldHideTopMatch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Deprecated event proto Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/proto/omnibox_event.proto

diff --git a/components/metrics/proto/omnibox_event.proto b/components/metrics/proto/omnibox_event.proto

index b3e6656344a1e180e94ee92726a9f79fba17123a..6bdca3ef269e740b6d82d963ec6ecb92e82ee238 100644

--- a/components/metrics/proto/omnibox_event.proto

+++ b/components/metrics/proto/omnibox_event.proto

@@ -39,8 +39,8 @@ message OmniboxEventProto {

// This corresponds the index of the |suggestion| below.

optional int32 selected_index = 5;

- // Whether or not the top match was hidden in the omnibox suggestions

- // dropdown.

+ // DEPRECATED. Whether or not the top match was hidden in the omnibox

+ // suggestions dropdown.

optional bool is_top_result_hidden_in_dropdown = 14;

groby-ooo-7-16 2015/05/27 19:25:51 mark with [deprecate = true]; see https://develope

dschuyler 2015/05/28 18:58:06 Done.

// Whether the omnibox popup is open. It can be closed if, for instance,