Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 115393004: Turn on inline signin by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_helper.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc
index 9d9768d1ee9a02b3d1a9db1bec00ca88cb6cc667..a5779ef2d6ea9505b85cf09f25aaa21c92546244 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc
@@ -12,7 +12,6 @@
#include "base/bind.h"
#include "base/callback_forward.h"
#include "base/callback_helpers.h"
-#include "base/command_line.h"
#include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop_proxy.h"
@@ -56,10 +55,10 @@
#include "chrome/browser/ui/tab_modal_confirm_dialog.h"
#include "chrome/browser/ui/tab_modal_confirm_dialog_delegate.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
-#include "chrome/common/chrome_switches.h"
#include "chrome/common/chrome_version_info.h"
#include "chrome/common/net/url_util.h"
#include "chrome/common/pref_names.h"
+#include "chrome/common/profile_management_switches.h"
#include "chrome/common/url_constants.h"
#include "components/autofill/core/common/password_form.h"
#include "content/public/browser/browser_thread.h"
@@ -412,8 +411,7 @@ void StartExplicitSync(const StartSyncArgs& args,
content::WebContents* contents,
OneClickSigninSyncStarter::StartSyncMode start_mode,
ConfirmEmailDialogDelegate::Action action) {
- bool enable_inline = CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableInlineSignin);
+ bool enable_inline = switches::IsEnableInlineSignin();
if (action == ConfirmEmailDialogDelegate::START_SYNC) {
StartSync(args, start_mode);
if (!enable_inline) {
@@ -779,14 +777,12 @@ bool OneClickSigninHelper::CanOffer(content::WebContents* web_contents,
OneClickSigninHelper::Offer OneClickSigninHelper::CanOfferOnIOThread(
net::URLRequest* request,
ProfileIOData* io_data) {
- return CanOfferOnIOThreadImpl(request->url(), request->referrer(),
- request, io_data);
+ return CanOfferOnIOThreadImpl(request->url(), request, io_data);
}
// static
OneClickSigninHelper::Offer OneClickSigninHelper::CanOfferOnIOThreadImpl(
const GURL& url,
- const std::string& referrer,
base::SupportsUserData* request,
ProfileIOData* io_data) {
if (!gaia::IsGaiaSignonRealm(url.GetOrigin()))
@@ -1169,8 +1165,6 @@ void OneClickSigninHelper::DidStartNavigationToPendingEntry(
// clear the internal state. This is needed to detect navigations in the
// middle of the sign in process that may redirect back to the sign in
// process (see crbug.com/181163 for details).
- const GURL continue_url = signin::GetNextPageURLForPromoURL(
- signin::GetPromoURL(signin::SOURCE_START_PAGE, false));
GURL::Replacements replacements;
replacements.ClearQuery();
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_helper.h ('k') | chrome/browser/ui/sync/one_click_signin_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698