Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: chrome/browser/ui/webui/inline_login_ui.cc

Issue 115393004: Turn on inline signin by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/profile_chooser_view.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/inline_login_ui.cc
diff --git a/chrome/browser/ui/webui/inline_login_ui.cc b/chrome/browser/ui/webui/inline_login_ui.cc
index c7c25fdaf30c0011534a5903dc2efe99b8bbf0f1..f28050f044a7690424ca84fe828904a7ea9b00ba 100644
--- a/chrome/browser/ui/webui/inline_login_ui.cc
+++ b/chrome/browser/ui/webui/inline_login_ui.cc
@@ -6,7 +6,6 @@
#include "base/atomic_sequence_num.h"
#include "base/bind.h"
-#include "base/command_line.h"
#include "base/memory/scoped_ptr.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
@@ -27,7 +26,6 @@
#include "chrome/browser/ui/sync/one_click_signin_helper.h"
#include "chrome/browser/ui/sync/one_click_signin_sync_starter.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
-#include "chrome/common/profile_management_switches.h"
#include "chrome/common/url_constants.h"
#include "content/public/browser/storage_partition.h"
#include "content/public/browser/web_contents.h"
@@ -137,50 +135,47 @@ class InlineLoginUIHandler : public GaiaAuthConsumer,
GaiaUrls* gaiaUrls = GaiaUrls::GetInstance();
params.SetString("gaiaUrl", gaiaUrls->gaia_url().spec());
- bool enable_inline = switches::IsEnableInlineSignin();
- params.SetInteger("authMode",
- enable_inline ? kInlineAuthMode : kDefaultAuthMode);
- // Set parameters specific for inline signin flow.
-#if !defined(OS_CHROMEOS)
- if (enable_inline) {
+#if defined(OS_CHROMEOS)
+ params.SetInteger("authMode", kDefaultAuthMode);
+#else
+ params.SetInteger("authMode", kInlineAuthMode);
- const GURL& current_url = web_ui()->GetWebContents()->GetURL();
- signin::Source source = signin::GetSourceForPromoURL(current_url);
- DCHECK(source != signin::SOURCE_UNKNOWN);
- if (source == signin::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT ||
- source == signin::SOURCE_AVATAR_BUBBLE_SIGN_IN) {
- // Drop the leading slash in the path.
- params.SetString("gaiaPath",
- gaiaUrls->embedded_signin_url().path().substr(1));
- }
+ const GURL& current_url = web_ui()->GetWebContents()->GetURL();
+ signin::Source source = signin::GetSourceForPromoURL(current_url);
+ DCHECK(source != signin::SOURCE_UNKNOWN);
+ if (source == signin::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT ||
+ source == signin::SOURCE_AVATAR_BUBBLE_SIGN_IN) {
+ // Drop the leading slash in the path.
+ params.SetString("gaiaPath",
+ gaiaUrls->embedded_signin_url().path().substr(1));
+ }
- params.SetString("service", "chromiumsync");
- params.SetString("continueUrl",
- signin::GetLandingURL("source", static_cast<int>(source)).spec());
-
- std::string email;
- net::GetValueForKeyInQuery(current_url, "Email", &email);
- if (!email.empty())
- params.SetString("email", email);
-
- std::string frame_url;
- net::GetValueForKeyInQuery(current_url, "frameUrl", &frame_url);
- if (!frame_url.empty())
- params.SetString("frameUrl", frame_url);
-
- std::string is_constrained;
- net::GetValueForKeyInQuery(current_url, "constrained", &is_constrained);
- if (!is_constrained.empty())
- params.SetString("constrained", is_constrained);
-
- net::GetValueForKeyInQuery(current_url, "partitionId", &partition_id_);
- if (partition_id_.empty()) {
- partition_id_ =
- "gaia-webview-" + base::IntToString(next_partition_id.GetNext());
- }
- params.SetString("partitionId", partition_id_);
+ params.SetString("service", "chromiumsync");
+ params.SetString("continueUrl",
+ signin::GetLandingURL("source", static_cast<int>(source)).spec());
+
+ std::string email;
+ net::GetValueForKeyInQuery(current_url, "Email", &email);
+ if (!email.empty())
+ params.SetString("email", email);
+
+ std::string frame_url;
+ net::GetValueForKeyInQuery(current_url, "frameUrl", &frame_url);
+ if (!frame_url.empty())
+ params.SetString("frameUrl", frame_url);
+
+ std::string is_constrained;
+ net::GetValueForKeyInQuery(current_url, "constrained", &is_constrained);
+ if (!is_constrained.empty())
+ params.SetString("constrained", is_constrained);
+
+ net::GetValueForKeyInQuery(current_url, "partitionId", &partition_id_);
+ if (partition_id_.empty()) {
+ partition_id_ =
+ "gaia-webview-" + base::IntToString(next_partition_id.GetNext());
}
+ params.SetString("partitionId", partition_id_);
#endif // OS_CHROMEOS
web_ui()->CallJavascriptFunction("inline.login.loadAuthExtension", params);
« no previous file with comments | « chrome/browser/ui/views/profile_chooser_view.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698