Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: chrome/browser/ui/android/javascript_app_modal_dialog_android.cc

Issue 1153813003: Add user_gesture param to WebContentsDelegate::ActivateContents Base URL: https://chromium.googlesource.com/chromium/src.git@ug1_WebContentsImpl_Activate
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/javascript_app_modal_dialog_android.cc
diff --git a/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc b/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc
index bf08bc53ee02d419c984a9e8e1f18d6fb65f999b..87cdaadad83d1cc86f98e950c28a3cc94de85291 100644
--- a/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc
+++ b/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc
@@ -174,8 +174,9 @@ class ChromeJavaScriptNativeDialogAndroidFactory
private:
app_modal::NativeAppModalDialog* CreateNativeJavaScriptDialog(
app_modal::JavaScriptAppModalDialog* dialog) override {
+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?
dialog->web_contents()->GetDelegate()->ActivateContents(
- dialog->web_contents());
+ dialog->web_contents(), false /* user_gesture */);
return new JavascriptAppModalDialogAndroid(
base::android::AttachCurrentThread(),
dialog, dialog->web_contents()->GetTopLevelNativeWindow());
« no previous file with comments | « chrome/browser/task_manager/task_manager.cc ('k') | chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698