Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1153813002: Remove init from GrGLContextInfo and caps classes (Closed)

Created:
5 years, 7 months ago by bsalomon
Modified:
5 years, 7 months ago
Reviewers:
joshualitt, jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove init from GrGLContextInfo and caps classes Make Gr*Caps, GrGLContext* noncopyable Committed: https://skia.googlesource.com/skia/+/424cc26add7ed491c6941d0c0c3a0e6d83190307

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -348 lines) Patch
M include/gpu/GrCaps.h View 1 2 chunks +2 lines, -19 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +1 line, -1 line 1 comment Download
M src/gpu/GrDrawTarget.cpp View 3 chunks +2 lines, -47 lines 0 comments Download
M src/gpu/GrGpuFactory.cpp View 1 chunk +2 lines, -28 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 4 chunks +6 lines, -33 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 5 chunks +9 lines, -93 lines 0 comments Download
M src/gpu/gl/GrGLContext.h View 3 chunks +17 lines, -42 lines 0 comments Download
M src/gpu/gl/GrGLContext.cpp View 1 chunk +46 lines, -61 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 5 chunks +13 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 9 chunks +30 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bsalomon
Trying to simplify the lifetime of these objects before a coming CL that will pass ...
5 years, 7 months ago (2015-05-22 16:18:36 UTC) #2
joshualitt
lgtm https://codereview.chromium.org/1153813002/diff/20001/src/effects/gradients/SkSweepGradient.cpp File src/effects/gradients/SkSweepGradient.cpp (right): https://codereview.chromium.org/1153813002/diff/20001/src/effects/gradients/SkSweepGradient.cpp#newcode280 src/effects/gradients/SkSweepGradient.cpp:280: const GrGLContextInfo& ctxInfo = builder->ctxInfo(); lol
5 years, 7 months ago (2015-05-22 17:29:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153813002/20001
5 years, 7 months ago (2015-05-22 17:31:24 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 17:37:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/424cc26add7ed491c6941d0c0c3a0e6d83190307

Powered by Google App Engine
This is Rietveld 408576698