src/effects/gradients/SkSweepGradient.cpp - Issue 1153813002: Remove init from GrGLContextInfo and caps classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkSweepGradient.cpp

Issue 1153813002: Remove init from GrGLContextInfo and caps classes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: cleanup Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkSweepGradient.cpp

diff --git a/src/effects/gradients/SkSweepGradient.cpp b/src/effects/gradients/SkSweepGradient.cpp

index 686d87742ed6a25fbc98bf58a5e7b654ef8d0ee9..ce4edae9b8a780c2f0c7d6719e46f322e62efddc 100644

--- a/src/effects/gradients/SkSweepGradient.cpp

+++ b/src/effects/gradients/SkSweepGradient.cpp

@@ -277,7 +277,7 @@ void GrGLSweepGradient::emitCode(GrGLFPBuilder* builder,

const GrSweepGradient& ge = fp.cast<GrSweepGradient>();

this->emitUniforms(builder, ge);

SkString coords2D = builder->getFragmentShaderBuilder()->ensureFSCoords2D(coords, 0);

- const GrGLContextInfo ctxInfo = builder->ctxInfo();

+ const GrGLContextInfo& ctxInfo = builder->ctxInfo();

joshualitt 2015/05/22 17:29:47 lol

SkString t;

// 0.1591549430918 is 1/(2*pi), used since atan returns values [-pi, pi]

// On Intel GPU there is an issue where it reads the second arguement to atan "- %s.x" as an int

« no previous file with comments | « include/gpu/GrCaps.h ('k') | src/gpu/GrDrawTarget.cpp » ('j') | no next file with comments »