Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: Source/bindings/modules/v8/V8BindingForModules.cpp

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/modules/v8/V8BindingForModules.cpp
diff --git a/Source/bindings/modules/v8/V8BindingForModules.cpp b/Source/bindings/modules/v8/V8BindingForModules.cpp
index 26d28151f187766ae8784cc4a4eabee00da58c99..e8f1c5efcbb640ce731a92e2dc76321660708543 100644
--- a/Source/bindings/modules/v8/V8BindingForModules.cpp
+++ b/Source/bindings/modules/v8/V8BindingForModules.cpp
@@ -112,8 +112,7 @@ v8::Local<v8::Value> toV8(const IDBKey* key, v8::Local<v8::Object> creationConte
v8::Local<v8::Value> value = toV8(key->array()[i].get(), creationContext, isolate);
if (value.IsEmpty())
value = v8::Undefined(isolate);
- // TODO(jsbell): Use DefineOwnProperty when exposed by V8. http://crbug.com/475206
- if (!v8CallBoolean(array->ForceSet(context, v8::Integer::New(isolate, i), value)))
+ if (!v8CallBoolean(array->CreateDataProperty(context, i, value)))
return v8Undefined();
}
return array;
@@ -375,8 +374,7 @@ static v8::Local<v8::Value> deserializeIDBValueArray(v8::Isolate* isolate, v8::L
v8::Local<v8::Value> v8Value = deserializeIDBValue(isolate, creationContext, values->at(i).get());
if (v8Value.IsEmpty())
v8Value = v8::Undefined(isolate);
- // TODO(cmumford): Use DefineOwnProperty when exposed by V8. http://crbug.com/475206
- if (!v8CallBoolean(array->ForceSet(context, v8::Integer::New(isolate, i), v8Value)))
+ if (!v8CallBoolean(array->CreateDataProperty(context, i, v8Value)))
return v8Undefined();
}
@@ -420,8 +418,7 @@ bool injectV8KeyIntoV8Value(v8::Isolate* isolate, v8::Local<v8::Value> key, v8::
return false;
} else {
value = v8::Object::New(isolate);
- // TODO(jsbell): Use DefineOwnProperty when exposed by V8. http://crbug.com/475206
- if (!v8CallBoolean(object->ForceSet(context, property, value)))
+ if (!v8CallBoolean(object->CreateDataProperty(context, property, value)))
return false;
}
}
@@ -435,8 +432,7 @@ bool injectV8KeyIntoV8Value(v8::Isolate* isolate, v8::Local<v8::Value> key, v8::
// If it's not an implicit property of value, value must be an object.
v8::Local<v8::Object> object = value.As<v8::Object>();
v8::Local<v8::String> property = v8String(isolate, keyPathElements.last());
- // TODO(jsbell): Use DefineOwnProperty when exposed by V8. http://crbug.com/475206
- if (!v8CallBoolean(object->ForceSet(context, property, key)))
+ if (!v8CallBoolean(object->CreateDataProperty(context, property, key)))
return false;
return true;

Powered by Google App Engine
This is Rietveld 408576698