Source/bindings/scripts/v8_attributes.py - Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp ('K') | « Source/bindings/modules/v8/V8BindingForModules.cpp ('k') | Source/bindings/templates/dictionary_v8.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index fba7307668aae0b9fd8f6fe9124b5848b9fc78bb..5f965fd2700b3e7ff5bf5bed6dd58f707e57d235 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -325,7 +325,7 @@ def setter_context(interface, attribute, context):

if ('Replaceable' in attribute.extended_attributes or

is_constructor_attribute(attribute)):

- context['cpp_setter'] = '%sForceSetAttributeOnThis(propertyName, v8Value, info)' % cpp_name(interface)

+ context['cpp_setter'] = '%sCreateDataProperty(propertyName, v8Value, info)' % cpp_name(interface)

return

extended_attributes = attribute.extended_attributes