bindings: Use CreateDataProperty() instead of ForceSet()

Source/bindings/modules/v8/V8BindingForModules.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 94 matching lines @@
         return toV8(DOMArrayBuffer::create(reinterpret_cast<const unsigned char*>(key->binary()->data()), key->binary()->size()), creationContext, isolate);
     case IDBKey::DateType:
         return v8::Date::New(context, key->date()).ToLocalChecked();
     case IDBKey::ArrayType:
         {
             v8::Local<v8::Array> array = v8::Array::New(isolate, key->array().size());
             for (size_t i = 0; i < key->array().size(); ++i) {
                 v8::Local<v8::Value> value = toV8(key->array()[i].get(), creationContext, isolate);
                 if (value.IsEmpty())
                     value = v8::Undefined(isolate);
-                // TODO(jsbell): Use DefineOwnProperty when exposed by V8. http://crbug.com/475206
-                if (!v8CallBoolean(array->ForceSet(context, v8::Integer::New(isolate, i), value)))
+                if (!v8CallBoolean(array->CreateDataProperty(context, i, value)))
                     return v8Undefined();
             }
             return array;
         }
     }
 
     ASSERT_NOT_REACHED();
     return v8Undefined();
 }
 
@@ skipping 241 matching lines @@
 static v8::Local<v8::Value> deserializeIDBValueArray(v8::Isolate* isolate, v8::Local<v8::Object> creationContext, const Vector<RefPtr<IDBValue>>* values)
 {
     ASSERT(isolate->InContext());
 
     v8::Local<v8::Context> context = isolate->GetCurrentContext();
     v8::Local<v8::Array> array = v8::Array::New(isolate, values->size());
     for (size_t i = 0; i < values->size(); ++i) {
         v8::Local<v8::Value> v8Value = deserializeIDBValue(isolate, creationContext, values->at(i).get());
         if (v8Value.IsEmpty())
             v8Value = v8::Undefined(isolate);
-        // TODO(cmumford): Use DefineOwnProperty when exposed by V8. http://crbug.com/475206
-        if (!v8CallBoolean(array->ForceSet(context, v8::Integer::New(isolate, i), v8Value)))
+        if (!v8CallBoolean(array->CreateDataProperty(context, i, v8Value)))
             return v8Undefined();
     }
 
     return array;
 }
 
 // This is only applied to deserialized values which were validated before
 // serialization, so various assumptions/assertions can be made.
 bool injectV8KeyIntoV8Value(v8::Isolate* isolate, v8::Local<v8::Value> key, v8::Local<v8::Value> value, const IDBKeyPath& keyPath)
 {
@@ skipping 23 matching lines @@
         v8::Local<v8::Object> object = value.As<v8::Object>();
         v8::Local<v8::String> property = v8String(isolate, keyPathElement);
         bool hasOwnProperty;
         if (!v8Call(object->HasOwnProperty(context, property), hasOwnProperty))
             return false;
         if (hasOwnProperty) {
             if (!object->Get(context, property).ToLocal(&value))
                 return false;
         } else {
             value = v8::Object::New(isolate);
-            // TODO(jsbell): Use DefineOwnProperty when exposed by V8. http://crbug.com/475206
-            if (!v8CallBoolean(object->ForceSet(context, property, value)))
+            if (!v8CallBoolean(object->CreateDataProperty(context, property, value)))
                 return false;
         }
     }
 
     // Implicit properties don't need to be set. The caller is not required to
     // be aware of this, so this is an expected no-op. The caller can verify
     // that the value is correct via assertPrimaryKeyValidOrInjectable.
     if (isImplicitProperty(isolate, value, keyPathElements.last()))
         return true;
 
     // If it's not an implicit property of value, value must be an object.
     v8::Local<v8::Object> object = value.As<v8::Object>();
     v8::Local<v8::String> property = v8String(isolate, keyPathElements.last());
-    // TODO(jsbell): Use DefineOwnProperty when exposed by V8. http://crbug.com/475206
-    if (!v8CallBoolean(object->ForceSet(context, property, key)))
+    if (!v8CallBoolean(object->CreateDataProperty(context, property, key)))
         return false;
 
     return true;
 }
 
 // Verify that an value can have an generated key inserted at the location
 // specified by the key path (by injectV8KeyIntoV8Value) when the object is
 // later deserialized.
 bool canInjectIDBKeyIntoScriptValue(v8::Isolate* isolate, const ScriptValue& scriptValue, const IDBKeyPath& keyPath)
 {
@@ skipping 89 matching lines @@
     ASSERT(!exceptionState.hadException());
     if (expectedKey && expectedKey->isEqual(value->primaryKey()))
         return;
 
     bool injected = injectV8KeyIntoV8Value(isolate, keyValue.v8Value(), scriptValue.v8Value(), value->keyPath());
     ASSERT_UNUSED(injected, injected);
 }
 #endif
 
 } // namespace blink