Issue 11536004: Remove all warnings from dart2js and add a test to prevent introduction of new.

Issue 11536004: Remove all warnings from dart2js and add a test to prevent introduction of new. (Closed)

Created:
8 years ago by ahe

Modified:
8 years ago

Reviewers:
karlklose, Anton Muhin, kasperl

CC:
reviews_dartlang.org, ngeoffray, Johnni Winther, erikcorry, sra1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove all warnings from dart2js and add a test to prevent introduction of new. Committed: https://code.google.com/p/dart/source/detail?r=15962

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -5 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js/nodes.dart	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/array_based_scanner.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
A	dart/tests/utils/dart2js_test.dart	View	1 chunk	+16 lines, -0 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

DBC https://codereview.chromium.org/11536004/diff/1/dart/tests/utils/dart2js_test.dart File dart/tests/utils/dart2js_test.dart (right): https://codereview.chromium.org/11536004/diff/1/dart/tests/utils/dart2js_test.dart#newcode11 dart/tests/utils/dart2js_test.dart:11: import '../../sdk/lib/_internal/compiler/implementation/dart2js.dart' Peter, we should use old style ...

8 years ago (2012-12-11 11:20:53 UTC) #4

ahe

8 years ago (2012-12-11 14:48:23 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/11536004/diff/1/dart/tests/utils/dart2js_test...
File dart/tests/utils/dart2js_test.dart (right):

https://codereview.chromium.org/11536004/diff/1/dart/tests/utils/dart2js_test...
dart/tests/utils/dart2js_test.dart:11: import
'../../sdk/lib/_internal/compiler/implementation/dart2js.dart'
On 2012/12/11 11:20:54, Anton Muhin wrote:
> Peter, we should use old style import here due to the wrapping we do :(
> 
> Otherwise, it breaks drt tests, alas

As you later discovered, it is not the import syntax that is the problem.  The
problem is that there is no library declaration.  This is a know bug in Dartium
tests and getting rid of wrapping will fix that bug.

Regardless, it is fine that this test fails on Dartium.  The sole purpose of
this test is to ensure that dart2js is free of warnings.

Expand Messages | Collapse Messages