dart/sdk/lib/_internal/compiler/implementation/scanner/array_based_scanner.dart - Issue 11536004: Remove all warnings from dart2js and add a test to prevent introduction of new.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/scanner/array_based_scanner.dart

Issue 11536004: Remove all warnings from dart2js and add a test to prevent introduction of new. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart ('k') | dart/tests/utils/dart2js_test.dart » ('j') | dart/tests/utils/dart2js_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/scanner/array_based_scanner.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/scanner/array_based_scanner.dart b/dart/sdk/lib/_internal/compiler/implementation/scanner/array_based_scanner.dart

index ea84f759473867904e08ad1769efb709c7bf92a3..01f8e9e8159abd4b2dc3286e9eafff04d9858afc 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/scanner/array_based_scanner.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/scanner/array_based_scanner.dart

@@ -179,6 +179,5 @@ class ArrayBasedScanner<S extends SourceString> extends AbstractScanner<S> {

}

- // TODO(ahe): make class abstract instead of adding an abstract method.

- peek();

+ void unmatchedBeginGroup(BeginGroupToken begin);

}