Make CPDFXFA_App / IXFA_AppProvider saner

Make CPDFXFA_App / IXFA_AppProvider saner

Move interface comments from the implementation header to the
interface header.

Replace Create / Release functions with static methods.

Replace dubious Release() methods with deletion via virtual dtor, also
for IXFA_App and IXFA_FontMgr while we're at it.

Untabify and fix (theoretically) illegal _CAP include guard definitions
for fpdfxfa/ headers.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/bdeeb8a036442302b821686a03698b0bb98952e1

[Tom Sepez, 2015-05-22 20:43:59]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-05-22 20:43:59]

Lei, for review.  I'm trying to see how invasive XFA is into the non-XFA side,
and its hard to follow the code as is ...

[Tom Sepez, 2015-05-26 18:31:35]

On 2015/05/22 20:43:59, Tom Sepez wrote:
> Lei, for review.  I'm trying to see how invasive XFA is into the non-XFA side,
> and its hard to follow the code as is ...

Closing.  Seems like too much churn.

[Tom Sepez, 2015-05-26 19:58:02]

And, its re-opened.  Lei, please review this smaller subset.

[Lei Zhang, 2015-05-27 02:18:40]

https://codereview.chromium.org/1153553003/diff/80001/fpdfsdk/include/fpdfxfa...
File fpdfsdk/include/fpdfxfa/fpdfxfa_app.h (right):

https://codereview.chromium.org/1153553003/diff/80001/fpdfsdk/include/fpdfxfa...
fpdfsdk/include/fpdfxfa/fpdfxfa_app.h:30: FX_BOOL            
InitRuntime(FX_BOOL bReset = FALSE) {
move impl to .cpp file?

https://codereview.chromium.org/1153553003/diff/80001/fpdfsdk/include/fpdfxfa...
fpdfsdk/include/fpdfxfa/fpdfxfa_app.h:41: CJS_RuntimeFactory*
GetRuntimeFactory() {return m_pJSRuntimeFactory;}
nit: add some spaces

https://codereview.chromium.org/1153553003/diff/80001/fpdfsdk/include/fpdfxfa...
fpdfsdk/include/fpdfxfa/fpdfxfa_app.h:80: static CPDFXFA_App* g_pApp;
Can this be declared in the .cpp file instead?

https://codereview.chromium.org/1153553003/diff/80001/fpdfsdk/src/fpdfxfa/fpd...
File fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp (right):

https://codereview.chromium.org/1153553003/diff/80001/fpdfsdk/src/fpdfxfa/fpd...
fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp:47: m_bInitRuntime = FALSE;
Put this in the initializer list?

https://codereview.chromium.org/1153553003/diff/80001/fpdfsdk/src/fpdfxfa/fpd...
fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp:59: if (m_hJSERuntime)
FXJSE_Runtime_Release() checks its input, so just call it?

https://codereview.chromium.org/1153553003/diff/80001/xfa/include/fxfa/fxfa.h
File xfa/include/fxfa/fxfa.h (right):

https://codereview.chromium.org/1153553003/diff/80001/xfa/include/fxfa/fxfa.h...
xfa/include/fxfa/fxfa.h:157: *Specifies the name of the client application in
which a form currently exists. Such as Exchange-Pro.
nit: space after *, ditto below

https://codereview.chromium.org/1153553003/diff/80001/xfa/include/fxfa/fxfa.h...
xfa/include/fxfa/fxfa.h:259: virtual ~IXFA_FontMgr() { }
Move dtor impl to xfa_fontmgr.cpp? Ditto below of IXFA_App.

[Tom Sepez, 2015-05-27 17:07:50]

https://codereview.chromium.org/1153553003/diff/80001/fpdfsdk/include/fpdfxfa...
File fpdfsdk/include/fpdfxfa/fpdfxfa_app.h (right):

https://codereview.chromium.org/1153553003/diff/80001/fpdfsdk/include/fpdfxfa...
fpdfsdk/include/fpdfxfa/fpdfxfa_app.h:30: FX_BOOL            
InitRuntime(FX_BOOL bReset = FALSE) {
On 2015/05/27 02:18:40, Lei Zhang wrote:
> move impl to .cpp file?

Done.

https://codereview.chromium.org/1153553003/diff/80001/fpdfsdk/include/fpdfxfa...
fpdfsdk/include/fpdfxfa/fpdfxfa_app.h:41: CJS_RuntimeFactory*
GetRuntimeFactory() {return m_pJSRuntimeFactory;}
On 2015/05/27 02:18:40, Lei Zhang wrote:
> nit: add some spaces

Done.

https://codereview.chromium.org/1153553003/diff/80001/fpdfsdk/include/fpdfxfa...
fpdfsdk/include/fpdfxfa/fpdfxfa_app.h:80: static CPDFXFA_App* g_pApp;
On 2015/05/27 02:18:40, Lei Zhang wrote:
> Can this be declared in the .cpp file instead?
I like having the static members rather than plain globals (as would be the case
if it were entirely in .cpp), so that other code outside the class in the .cpp
doesn't get a chance to muck with it.

https://codereview.chromium.org/1153553003/diff/80001/fpdfsdk/src/fpdfxfa/fpd...
File fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp (right):

https://codereview.chromium.org/1153553003/diff/80001/fpdfsdk/src/fpdfxfa/fpd...
fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp:47: m_bInitRuntime = FALSE;
On 2015/05/27 02:18:40, Lei Zhang wrote:
> Put this in the initializer list?

Done.

https://codereview.chromium.org/1153553003/diff/80001/fpdfsdk/src/fpdfxfa/fpd...
fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp:59: if (m_hJSERuntime)
On 2015/05/27 02:18:40, Lei Zhang wrote:
> FXJSE_Runtime_Release() checks its input, so just call it?

Done.

https://codereview.chromium.org/1153553003/diff/80001/xfa/include/fxfa/fxfa.h
File xfa/include/fxfa/fxfa.h (right):

https://codereview.chromium.org/1153553003/diff/80001/xfa/include/fxfa/fxfa.h...
xfa/include/fxfa/fxfa.h:157: *Specifies the name of the client application in
which a form currently exists. Such as Exchange-Pro.
On 2015/05/27 02:18:40, Lei Zhang wrote:
> nit: space after *, ditto below

Done.

https://codereview.chromium.org/1153553003/diff/80001/xfa/include/fxfa/fxfa.h...
xfa/include/fxfa/fxfa.h:259: virtual ~IXFA_FontMgr() { }
On 2015/05/27 02:18:40, Lei Zhang wrote:
> Move dtor impl to xfa_fontmgr.cpp? Ditto below of IXFA_App.

Done.

[Lei Zhang, 2015-05-27 17:35:34]

lgtm

[Tom Sepez, 2015-05-27 19:25:18]

Committed patchset #6 (id:100001) manually as
bdeeb8a036442302b821686a03698b0bb98952e1 (presubmit successful).