Make CPDFXFA_App / IXFA_AppProvider saner

xfa/src/fxfa/src/app/xfa_fontmgr.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../foxitlib.h"
 #include "../common/xfa_common.h"
 #include "xfa_fontmgr.h"
 #include "xfa_ffdoc.h"
@@ skipping 992 matching lines @@
             iStart = iMid + 1;
         } else {
             iEnd = iMid - 1;
         }
     } while (iEnd >= iStart);
     return pFontInfo;
 #else
     return NULL;
 #endif
 }
-IXFA_FontMgr* XFA_GetDefaultFontMgr()
+// static
+IXFA_FontMgr* IXFA_FontMgr::CreateDefault()
 {
     return FX_NEW CXFA_DefFontMgr;
 }
+// virtual
+IXFA_FontMgr::~IXFA_FontMgr()
+{
+}
 CXFA_DefFontMgr::~CXFA_DefFontMgr()
 {
     FX_INT32 iCounts = m_CacheFonts.GetSize();
     for (FX_INT32 i = 0; i < iCounts; i++) {
         ((IFX_Font*)m_CacheFonts[i])->Release();
     }
     m_CacheFonts.RemoveAll();
 }
 #define _FXFA_USEGASFONTMGR_
 IFX_Font* CXFA_DefFontMgr::GetFont(XFA_HDOC hDoc, FX_WSTR wsFontFamily, FX_DWORD dwFontStyles, FX_WORD wCodePage )
@@ skipping 343 matching lines @@
             delete pMgr;
         }
     }
     m_PDFFontMgrArray.RemoveAll();
     m_FontArray.RemoveAll();
 }
 void CXFA_FontMgr::SetDefFontMgr(IXFA_FontMgr* pFontMgr)
 {
     m_pDefFontMgr = pFontMgr;
 }