xfa/src/fxfa/src/app/xfa_fontmgr.h - Issue 1153553003: Make CPDFXFA_App / IXFA_AppProvider saner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxfa/src/app/xfa_fontmgr.h

Issue 1153553003: Make CPDFXFA_App / IXFA_AppProvider saner (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Address comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxfa/src/app/xfa_fontmgr.h

diff --git a/xfa/src/fxfa/src/app/xfa_fontmgr.h b/xfa/src/fxfa/src/app/xfa_fontmgr.h

index 09e0d19096b0da8a2c217ea025475a85552efa5b..fd65570115fcd576c143adc336090ea3f40437ae 100644

--- a/xfa/src/fxfa/src/app/xfa_fontmgr.h

+++ b/xfa/src/fxfa/src/app/xfa_fontmgr.h

@@ -17,11 +17,7 @@ class CXFA_DefFontMgr : public IXFA_FontMgr

{

public:

CXFA_DefFontMgr() {}

- virtual ~CXFA_DefFontMgr();

- virtual void Release()

- {

- delete this;

- }

+ ~CXFA_DefFontMgr() override;

virtual IFX_Font* GetFont(XFA_HDOC hDoc, FX_WSTR wsFontFamily, FX_DWORD dwFontStyles, FX_WORD wCodePage = 0xFFFF);

virtual IFX_Font* GetDefaultFont(XFA_HDOC hDoc, FX_WSTR wsFontFamily, FX_DWORD dwFontStyles, FX_WORD wCodePage = 0xFFFF);

protected:

« no previous file with comments | « xfa/src/fxfa/src/app/xfa_ffapp.cpp ('k') | xfa/src/fxfa/src/app/xfa_fontmgr.cpp » ('j') | no next file with comments »