Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1153203003: Update buildbot_tool and builders.pyl templates to remove 'master_type'. (Closed)

Created:
5 years, 6 months ago by Dirk Pranke
Modified:
5 years, 6 months ago
Reviewers:
nodir
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Update buildbot_tool and builders.pyl templates to remove 'master_type'. With the impending changes to builders.pyl-based buildbot masters to support multiple schedulers, we will no longer need to support different templates for tryservers and waterfall masters, since a given master may have both kinds of bots (and the distinction isn't really meaningful in the code, though it can still be useful to users). This change removes the 'master_type' field from the builders.pyl format, and now all of the master classes will explicitly note whether buildbucket_bucket and service_account_file were set (or not). R=nodir@chromium.org BUG=492876 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295462

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -177 lines) Patch
M masters/master.chromium.mojo/builders.pyl View 1 chunk +0 lines, -1 line 0 comments Download
M masters/master.chromium.mojo/master_site_config.py View 1 chunk +2 lines, -0 lines 0 comments Download
M masters/master.client.catapult/builders.pyl View 2 chunks +1 line, -2 lines 0 comments Download
M masters/master.client.catapult/master_site_config.py View 1 chunk +2 lines, -0 lines 0 comments Download
M masters/master.client.crashpad/builders.pyl View 1 chunk +0 lines, -1 line 0 comments Download
M masters/master.client.crashpad/master_site_config.py View 1 chunk +2 lines, -0 lines 0 comments Download
M masters/master.client.gyp/builders.pyl View 1 chunk +0 lines, -1 line 0 comments Download
M masters/master.client.gyp/master_site_config.py View 1 chunk +2 lines, -0 lines 0 comments Download
M masters/master.tryserver.client.catapult/builders.pyl View 2 chunks +1 line, -2 lines 0 comments Download
M scripts/common/chromium_utils.py View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/master/master_gen.py View 1 chunk +3 lines, -2 lines 0 comments Download
M scripts/master/unittests/master_gen_test.py View 1 chunk +0 lines, -19 lines 1 comment Download
M scripts/tools/buildbot_tool.py View 1 chunk +2 lines, -3 lines 0 comments Download
A + scripts/tools/buildbot_tool_templates/Makefile View 0 chunks +-1 lines, --1 lines 0 comments Download
A + scripts/tools/buildbot_tool_templates/buildbot View 0 chunks +-1 lines, --1 lines 0 comments Download
A + scripts/tools/buildbot_tool_templates/buildbot.tac View 0 chunks +-1 lines, --1 lines 0 comments Download
A + scripts/tools/buildbot_tool_templates/master.cfg View 0 chunks +-1 lines, --1 lines 0 comments Download
A + scripts/tools/buildbot_tool_templates/master_site_config.py View 1 chunk +2 lines, -0 lines 0 comments Download
D scripts/tools/buildbot_tool_templates/tryserver/Makefile View 1 chunk +0 lines, -8 lines 0 comments Download
D scripts/tools/buildbot_tool_templates/tryserver/buildbot View 1 chunk +0 lines, -11 lines 0 comments Download
D scripts/tools/buildbot_tool_templates/tryserver/buildbot.tac View 1 chunk +0 lines, -16 lines 0 comments Download
D scripts/tools/buildbot_tool_templates/tryserver/master.cfg View 1 chunk +0 lines, -22 lines 0 comments Download
D scripts/tools/buildbot_tool_templates/tryserver/master_site_config.py View 1 chunk +0 lines, -18 lines 0 comments Download
D scripts/tools/buildbot_tool_templates/waterfall/Makefile View 1 chunk +0 lines, -8 lines 0 comments Download
D scripts/tools/buildbot_tool_templates/waterfall/buildbot View 1 chunk +0 lines, -11 lines 0 comments Download
D scripts/tools/buildbot_tool_templates/waterfall/buildbot.tac View 1 chunk +0 lines, -16 lines 0 comments Download
D scripts/tools/buildbot_tool_templates/waterfall/master.cfg View 1 chunk +0 lines, -22 lines 0 comments Download
D scripts/tools/buildbot_tool_templates/waterfall/master_site_config.py View 1 chunk +0 lines, -16 lines 0 comments Download
M scripts/tools/unittests/buildbot_tool_test.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dirk Pranke
This CL does some trivial cleanup prior to the main work to add support for ...
5 years, 6 months ago (2015-05-29 01:55:38 UTC) #1
Dirk Pranke
Oh, and the corresponding doc change is in https://codereview.chromium.org/1143393004/ .
5 years, 6 months ago (2015-05-29 01:55:58 UTC) #2
nodir
lgtm
5 years, 6 months ago (2015-05-29 03:31:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153203003/1
5 years, 6 months ago (2015-05-29 20:40:46 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 20:45:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295462

Powered by Google App Engine
This is Rietveld 408576698