Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: scripts/master/master_gen.py

Issue 1153203003: Update buildbot_tool and builders.pyl templates to remove 'master_type'. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/master/master_gen.py
diff --git a/scripts/master/master_gen.py b/scripts/master/master_gen.py
index 21abe75c4bbfa6af84e04e01856e81f0639d1539..dd04a666aaf8ed42b87330279c42985a011702a3 100644
--- a/scripts/master/master_gen.py
+++ b/scripts/master/master_gen.py
@@ -41,12 +41,13 @@ def _Populate(BuildmasterConfig, builders, active_master_cls):
c,
require_dbconfig=active_master_cls.is_production_host)
- if builders['master_type'] == 'waterfall':
+ # TODO(dpranke): crbug.com/492876. Rework this when we add support for
+ # multiple schedulers.
+ if 'git_repo_url' in builders:
change_source = gitiles_poller.GitilesPoller(builders['git_repo_url'])
c['change_source'] = [change_source]
tag_comparator = change_source.comparator
else:
- assert builders['master_type'] == 'tryserver'
c['change_source'] = []
c['mergeRequests'] = False
tag_comparator = None

Powered by Google App Engine
This is Rietveld 408576698