Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: scripts/common/chromium_utils.py

Issue 1153203003: Update buildbot_tool and builders.pyl templates to remove 'master_type'. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/common/chromium_utils.py
diff --git a/scripts/common/chromium_utils.py b/scripts/common/chromium_utils.py
index d8ed085d5e4a2d2c5611875d7df8ee1acd21c33a..b41cd448c036ef0418a768f7692e8fb78504cf36 100644
--- a/scripts/common/chromium_utils.py
+++ b/scripts/common/chromium_utils.py
@@ -1852,6 +1852,15 @@ def ParseBuildersFileContents(path, contents):
builders.setdefault('buildbot_url',
'https://build.chromium.org/p/%s/' % buildbot_path)
+ builders.setdefault('buildbucket_bucket', None)
+ builders.setdefault('service_account_file', None)
+
+ # The _str fields are printable representations of Python values:
+ # if builders['foo'] == "hello", then builders['foo_str'] == "'hello'".
+ # This allows them to be read back in by Python scripts properly.
+ builders['buildbucket_bucket_str'] = repr(builders['buildbucket_bucket'])
+ builders['service_account_file_str'] = repr(builders['service_account_file'])
+
return builders

Powered by Google App Engine
This is Rietveld 408576698