Re-land: gin: Use V8 Maybe APIs

content/shell/renderer/test_runner/event_sender.cc

Index: content/shell/renderer/test_runner/event_sender.cc
diff --git a/content/shell/renderer/test_runner/event_sender.cc b/content/shell/renderer/test_runner/event_sender.cc
index a6482a7d3c5bd244f76ad30bdee9e107b112904f..b79e3c4a640afada105d999c53d65b65531d401f 100644
--- a/content/shell/renderer/test_runner/event_sender.cc
+++ b/content/shell/renderer/test_runner/event_sender.cc
@@ -121,8 +121,9 @@ int GetKeyModifiersFromV8(v8::Local<v8::Value> value) {
   if (value->IsString()) {
     modifier_names.push_back(gin::V8ToString(value));
   } else if (value->IsArray()) {
+    v8::Isolate* isolate = blink::mainThreadIsolate();
     gin::Converter<std::vector<std::string> >::FromV8(
-        NULL, value, &modifier_names);
+        isolate, value, &modifier_names);

[bashi, 2015/05/29 08:20:34]

This is the only diff from the original CL.

[jochen (gone - plz use gerrit), 2015/05/29 11:28:29]

can you add the Isolate* as argument to this method? All callsites have a
gin::Arguments instance from which you can get the isolate

[bashi, 2015/06/02 00:12:05]

Done.

   }
   return GetKeyModifiers(modifier_names);
 }