Refactor compile_js.gypi to support script_args and closure_args

remoting/compile_js.gypi

Index: remoting/compile_js.gypi
diff --git a/remoting/compile_js.gypi b/remoting/compile_js.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..90cb0da43f07ffa53049221f9028b554ecd78dee
--- /dev/null
+++ b/remoting/compile_js.gypi
@@ -0,0 +1,22 @@
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+#
+# remoting/compile_js.gypi

[Dan Beam, 2015/06/01 22:57:39]

can remove this as from the path it's clear (I just added it to make it clear in
the really free-form text area that we publish comments in)

+{
+  'variables': {
+    'closure_args!': [
+      '--jscomp_off=duplicate',
+      '--jscomp_off=misplacedTypeAnnotation',
+    ],
+    'closure_args': [
+      '--jscomp_error=reportUnknownTypes',
+      '--jscomp_error=duplicate',
+      '--jscomp_error=misplacedTypeAnnotation',
+    ],
+    'script_args' : [

[Dan Beam, 2015/06/01 22:57:39]

'script_args': ['--no-single-file'],

[Theresa, 2015/06/02 22:02:12]

Done.

+      '--no-single-file',
+    ],
+  },
+  'includes': [ '../third_party/closure_compiler/compile_js.gypi' ],

[Dan Beam, 2015/06/01 22:57:39]

i'd say mild preference to do:

  'list_name': ['one_item'],  # no extra \s or \n

when there's only 1 item in a list and

  'list_name': [
    '--flag1',
    '--flag2',
  ],

when there's 2+.  whatever we land on, we should be consistent

[Theresa, 2015/06/02 22:02:12]

Done.

+}