remoting/compile_js.gypi - Issue 1152583011: Refactor compile_js.gypi to support script_args and closure_args

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/compile_js.gypi

Issue 1152583011: Refactor compile_js.gypi to support script_args and closure_args (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added remoting/compile_js.gypi and decoupled target_name from source_files Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/resources/enhanced_bookmarks/enhanced_bookmarks.gypi ('K') | « components/resources/enhanced_bookmarks/enhanced_bookmarks.gypi ('k') | remoting/remoting_key_tester.gypi » ('j') | remoting/remoting_key_tester.gypi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4 #

	5 # remoting/compile_js.gypi
	Dan Beam 2015/06/01 22:57:39 can remove this as from the path it's clear (I jus can remove this as from the path it's clear (I just added it to make it clear in the really free-form text area that we publish comments in)
	6 {

	7 'variables': {

	8 'closure_args!': [

	9 '--jscomp_off=duplicate',

	10 '--jscomp_off=misplacedTypeAnnotation',

	11 ],

	12 'closure_args': [

	13 '--jscomp_error=reportUnknownTypes',

	14 '--jscomp_error=duplicate',

	15 '--jscomp_error=misplacedTypeAnnotation',

	16 ],

	17 'script_args' : [
	Dan Beam 2015/06/01 22:57:39 'script_args': ['--no-single-file'], 'script_args': ['--no-single-file'], Theresa 2015/06/02 22:02:12 Done. Show quoted text On 2015/06/01 22:57:39, Dan Beam wrote: > 'script_args': ['--no-single-file'], Done.
	18 '--no-single-file',

	19 ],

	20 },

	21 'includes': [ '../third_party/closure_compiler/compile_js.gypi' ],
	Dan Beam 2015/06/01 22:57:39 i'd say mild preference to do: 'list_name': ['o i'd say mild preference to do: 'list_name': ['one_item'], # no extra \s or \n when there's only 1 item in a list and 'list_name': [ '--flag1', '--flag2', ], when there's 2+. whatever we land on, we should be consistent Theresa 2015/06/02 22:02:12 Done. Show quoted text On 2015/06/01 22:57:39, Dan Beam wrote: > i'd say mild preference to do: > > 'list_name': ['one_item'], # no extra \s or \n > > when there's only 1 item in a list and > > 'list_name': [ > '--flag1', > '--flag2', > ], > > when there's 2+. whatever we land on, we should be consistent Done.
	22 }

OLD	NEW