Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: remoting/remoting_key_tester.gypi

Issue 1152583011: Refactor compile_js.gypi to support script_args and closure_args (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added remoting/compile_js.gypi and decoupled target_name from source_files Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/remoting_key_tester.gypi
diff --git a/remoting/remoting_key_tester.gypi b/remoting/remoting_key_tester.gypi
index ba16e417ed519847ded765c662be3a4084d99ea7..7b776b0e1ed80ea5454866bd5a72cb181589f491 100644
--- a/remoting/remoting_key_tester.gypi
+++ b/remoting/remoting_key_tester.gypi
@@ -49,29 +49,19 @@
['run_jscompile != 0', {
'variables': {
'success_stamp': '<(PRODUCT_DIR)/<(_target_name).stamp',
+ 'source_files': [
+ '<@(remoting_key_tester_js_files)',
+ 'webapp/js_proto/chrome_proto.js',
+ 'webapp/js_proto/chrome_event_proto.js',
+ ],
+ 'script_args' : [
Dan Beam 2015/06/01 22:57:39 'script_args': [
Theresa 2015/06/02 22:02:12 Done.
+ '--success-stamp', '<(success_stamp)',
+ '--out_file', '<(success_stamp)',
+ ]
},
- 'actions': [
- {
- 'action_name': 'jscompile remoting_key_tester',
- 'inputs': [
- '<@(remoting_key_tester_js_files)',
- 'webapp/js_proto/chrome_proto.js',
- 'webapp/js_proto/chrome_event_proto.js',
- ],
- 'outputs': [
- '<(success_stamp)',
- ],
- 'action': [
- 'python', '../third_party/closure_compiler/compile.py',
- '--strict',
- '--no-single-file',
- '--success-stamp', '<(success_stamp)',
- '<@(remoting_key_tester_js_files)',
- 'webapp/js_proto/chrome_proto.js',
- 'webapp/js_proto/chrome_event_proto.js',
- ],
- },
- ], # actions
+ 'includes': [
+ 'compile_js.gypi'
+ ],
Dan Beam 2015/06/01 22:57:39 'includes': ['compile_js.gypi'],
Theresa 2015/06/02 22:02:12 Done.
}],
],
}, # end of target 'remoting_key_tester_jscompile'

Powered by Google App Engine
This is Rietveld 408576698